[Php81] Skip as Arg value not callable type on ArrayToFirstClassCallableRector#7762
Closed
samsonasik wants to merge 7 commits intomainfrom
Closed
[Php81] Skip as Arg value not callable type on ArrayToFirstClassCallableRector#7762samsonasik wants to merge 7 commits intomainfrom
samsonasik wants to merge 7 commits intomainfrom
Conversation
Member
|
@samsonasik Just checking, is this something we should ship in next release or does it require more work? |
Member
Author
|
@TomasVotruba it require more work, I will continue later |
Member
|
Got it 👍 |
samsonasik
force-pushed
the
skip-as-arg
branch
from
9a3b2c3 to
31e3a4c
Compare
samsonasik
changed the title
samsonasik
changed the title
samsonasik
force-pushed
the
skip-as-arg
branch
from
efdc577 to
57aa727
Compare
Member
Author
|
Closing for now as used on multiple cases and some cases are valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9563
Also update existing fixture to skip
factory()on services symfony config as not allow callable, see https://github.com/symfony/dependency-injection/blob/bf7359d13a5746908ee51dd72ab195f578aae0e3/Loader/Configurator/Traits/FactoryTrait.php#L25